Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify the client version. #2965

Merged
merged 14 commits into from
Sep 30, 2021
Merged

Verify the client version. #2965

merged 14 commits into from
Sep 30, 2021

Conversation

CPWstatic
Copy link
Contributor

@CPWstatic CPWstatic commented Sep 28, 2021 •
edited
Loading

nebua python client had been updated. vesoft-inc/nebula-python#148

@CPWstatic CPWstatic added the wip Solution: work in progress label Sep 28, 2021
@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Sep 28, 2021
@CPWstatic CPWstatic force-pushed the check_client_version2 branch from 54cd036 to f6fc10d Compare September 28, 2021 12:34
@CPWstatic CPWstatic added ready-for-testing PR: ready for the CI test and removed wip Solution: work in progress labels Sep 29, 2021
yixinglu
yixinglu reviewed Sep 29, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our clients need to verify the version compatibility

src/graph/service/GraphFlags.cpp Outdated Show resolved Hide resolved
src/interface/common.thrift Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #2965 (f6fc10d) into master (dddf54e) will decrease coverage by 0.94%.
The diff coverage is 53.39%.

❗ Current head f6fc10d differs from pull request most recent head 3cb595e. Consider uploading reports for the commit 3cb595e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2965      +/-   ##
==========================================
- Coverage   85.47%   84.52%   -0.95%     
==========================================
  Files        1229     1259      +30     
  Lines      110375   112168    +1793     
==========================================
+ Hits        94341    94810     +469     
- Misses      16034    17358    +1324
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/clients/storage/GraphStorageClient.h 100.00% <ø> (ø)
src/clients/storage/InternalStorageClient.cpp 0.00% <0.00%> (ø)
src/clients/storage/InternalStorageClient.h 0.00% <ø> (-100.00%) ⬇️
src/clients/storage/StorageClientBase.h 59.32% <ø> (+6.94%) ⬆️
src/common/utils/NebulaKeyUtils.cpp 89.03% <0.00%> (-4.89%) ⬇️
src/common/utils/NebulaKeyUtils.h 80.68% <ø> (+2.65%) ⬆️
src/graph/executor/mutate/InsertExecutor.cpp 100.00% <ø> (ø)
src/graph/planner/SequentialPlanner.cpp 100.00% <ø> (ø)
src/graph/planner/plan/Admin.cpp 54.23% <0.00%> (-2.40%) ⬇️
... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c444b0f...3cb595e. Read the comment docs.

@CPWstatic CPWstatic force-pushed the check_client_version2 branch from 3cb595e to 07e1bca Compare September 29, 2021 13:55
yixinglu
yixinglu previously approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CPWstatic CPWstatic force-pushed the check_client_version2 branch from 64b6fed to 423d9fc Compare September 30, 2021 11:08
@yixinglu yixinglu merged commit 6f80804 into vesoft-inc:master Sep 30, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Oct 2, 2021
Closed
@CPWstatic CPWstatic mentioned this pull request Oct 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

@yixinglu yixinglu yixinglu approved these changes

@czpmango czpmango Awaiting requested review from czpmango

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@CPWstatic @codecov-commenter @yixinglu @Shylock-Hg @Sophie-Xie